Handle conflict error when overwriting immutable tags#1
Open
nikbanerjee-unity wants to merge 1 commit intomainfrom
Open
Handle conflict error when overwriting immutable tags#1nikbanerjee-unity wants to merge 1 commit intomainfrom
nikbanerjee-unity wants to merge 1 commit intomainfrom
Conversation
nikbanerjee-unity
force-pushed
the
feat/immutable-tag-conflict
branch
3 times, most recently
from
e63153f to
f1bf3e6
Compare
Signed-off-by: Nikhil Banerjee <nikhil.banerjee@unity3d.com>
nikbanerjee-unity
force-pushed
the
feat/immutable-tag-conflict
branch
from
f1bf3e6 to
419abe8
Compare
nweedon-u
approved these changes
Apr 20, 2022
This was referenced Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability for the registry to add tag validation, making the tags immutable, and to surface an adequate message back to the user should they try to overwrite an immutable tag.
This was attempted previously in this PR but was closed and supposed to be reworked into master but never did.
Signed-off-by: Nikhil Banerjee nikhil.banerjee@unity3d.com